-
-
Notifications
You must be signed in to change notification settings - Fork 307
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use ${CC} instead of "cc" for linking on mac #611
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
cc -> ${CC}
makes sense and it is indeed consistent with other code, but the configure
file is generated from configure.in
(one of the few or perhaps the only file generated which is in the repo). It is generated using autoconf-2.13
. I don't see this piece in configure.in
. We could merge this change, no harm in that, but the next update of configure
from configure.in
will remove this again.
I get the
|
Since configure is a generated file, the problem needs to be fixed in the file from which it is generated, which is aclocal.m4. |
Yes, here: Line 513 in 6956d2b
|
Thanks a lot to all of you, really appreciate it. Pushed changes to aclocal.m4 too. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
OK, now it makes sense to me. I don't see any further occurrences of this with grep -IrnE "SHLIB_LD[^a-z]*cc"
. Unless somebody adds another review or comment raising some new issues, I'm going to merge this soon. Thanks @nilason, @neteler and @ryandesign.
The failed Python code check is unrelated to this PR and already fixed on master (new version of Flake8 was released catching more errors). The fails on master after merging this are unrelated too ( |
@neteler Please backport this before 7.8.4. |
Replaces a hardcoded cc by a configured ${CC} in SHLIB_LD. Fixes #609.
Sure: done. |
Fixes: #609.