Update CMake build dependencies: Remove include(CTest) (/w enable_testing() still set) and fix Google Benchmark #162
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
thbeu
commented
Oct 25, 2024
thbeu
commented
- CTest dependency is not required and considered controversial because it introduces extra build targets
- Google Benchmark can no longer be downloaded with shallow flag set
thbeu
changed the title
really ? by whom ? Or is it just "include(CTest)"? But isn't that necessary to run ctest? |
thbeu
changed the title
rouault
added a commit
to rouault/gdal
that referenced
this pull request
Oct 25, 2024
According to Craig Scott in https://discourse.cmake.org/t/is-there-any-reason-to-prefer-include-ctest-or-enable-testing-over-the-other/1905/2 , using include(CTest) adds unnecessary clutter that is only needed for dashboard submission. enable_testing() is enough otherwise "Port" of OSGeo/shapelib#162
rouault
added a commit
to rouault/PROJ
that referenced
this pull request
Oct 25, 2024
According to Craig Scott in https://discourse.cmake.org/t/is-there-any-reason-to-prefer-include-ctest-or-enable-testing-over-the-other/1905/2 , using include(CTest) adds unnecessary clutter that is only needed for dashboard submission. enable_testing() is enough otherwise "Port" of OSGeo/shapelib#162
rouault
added a commit
to rouault/gdal
that referenced
this pull request
Oct 25, 2024
According to Craig Scott in https://discourse.cmake.org/t/is-there-any-reason-to-prefer-include-ctest-or-enable-testing-over-the-other/1905/2 , using include(CTest) adds unnecessary clutter that is only needed for dashboard submission. enable_testing() is enough otherwise "Port" of OSGeo/shapelib#162
rouault
added a commit
to rouault/PROJ
that referenced
this pull request
Oct 25, 2024
According to Craig Scott in https://discourse.cmake.org/t/is-there-any-reason-to-prefer-include-ctest-or-enable-testing-over-the-other/1905/2 , using include(CTest) adds unnecessary clutter that is only needed for dashboard submission. enable_testing() is enough otherwise "Port" of OSGeo/shapelib#162
rouault
added a commit
to rouault/geos
that referenced
this pull request
Oct 25, 2024
According to Craig Scott in https://discourse.cmake.org/t/is-there-any-reason-to-prefer-include-ctest-or-enable-testing-over-the-other/1905/2 , using include(CTest) adds unnecessary clutter that is only needed for dashboard submission. enable_testing() is enough otherwise "Port" of OSGeo/shapelib#162
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.