Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Node 16 branch #194

Merged
merged 5 commits into from
Dec 21, 2022
Merged

Node 16 branch #194

merged 5 commits into from
Dec 21, 2022

Conversation

solderq35
Copy link
Contributor

@solderq35 solderq35 commented Dec 20, 2022

Referencing this issue: #188

Tested on Node v16.15.1

EDIT: Full steps to avoid errors (at least for me):

  • delete package-lock.json
  • delete node_modules folder
  • run npm i --legacy-peer-deps
  • run npm run serve

Main changes: Switched from node-sass to Sass.

Note: While installing node modules, Sass module may throw out some warnings regarding other modules, e.g. twbs/bootstrap#34051

This build will not work on Node 17 and higher, to make it compatible on Node 17+, check here: vuejs/vue-cli#6770 (comment)

Edit:
Possible follow-up tasks:

  • Update README.md to reference node v16 instead of node v12
  • Maybe update backend/template.yaml to use node v16

@MilanDonhowe
Copy link
Contributor

I pushed a change which hardcodes the vue & vue-template versions which were triggering the previous build error and requiring us to use --legacy-peer-deps as a command line argument to the npm install command. @solderq35 if you could double check that it works on your end then I think we can go ahead and merge this into the main branch.

@solderq35
Copy link
Contributor Author

Looks good, confirmed I was able to switch to the node-16 branch from master and install everything by just running npm install this time.

@solderq35 solderq35 closed this Dec 21, 2022
@solderq35 solderq35 reopened this Dec 21, 2022
@solderq35 solderq35 merged commit 0f829d9 into master Dec 21, 2022
@solderq35 solderq35 deleted the node-16-branch branch February 22, 2023 06:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants