Feature Add and Update #26

ghost · 2021-05-14T04:48:38Z

Changed some line of script and Updated more in it like Contribution Header. Defined requirements paragraph. It will help more to engage with contributors and developers to contribute.

I tried to summarize the documentation to more better in this Python project.

Changed some line of script and Updated more in it like Contribution Header. Defined Requirments paragraph. It will help more to engage with contributors and developers to contribute.

ghost · 2021-06-11T04:04:58Z

this PR related to issue #28

Cyb3rWard0g · 2021-06-11T06:47:17Z

Thank you very much @thegautamkumarjaiswal ! I believe the contribution section needs some updates from a grammar perspective. I will read it again tomorrow.

ghost · 2021-06-11T07:06:36Z

And I am thinking, create seperate CONTRIBUTING.md file for contrubtion related guildelines.

osV22

A few suggestions for the Contribution section, I noted some things that perhaps can be of help.

Contributions

Contributions are appreciated given the number of projects @Cyb3rWard0g is often working on.

There is no strict guideline, but please be mindful of the following:

One pull request per issue
Select one or more label when you submit an issue
Make sure you are in the correct branch [Master]
Try to avoid sizeable changes unless warranted
Be patient and polite as the project is still relatively small; which is why we would appreciate your help where possible

Added the Guidelines to main the Project.

ghost · 2021-06-12T17:05:58Z

@Cyb3rWard0g @osV22 Please review the PR and suggest if needed or merge the PR.

Cyb3rWard0g · 2021-07-03T07:38:02Z

CONTRIBUTING.md

+  * [Pull Request](#step-6--pull-request)
+
+## Code of Conduct
+This project and everyone participating in it is governed by the Contributor Covenant. Make sure to read it here: [CODE_OF_CONDUCT.md](https://github.com/thegautamkumarjaiswal/ATTACK-Python-Client/blob/master/CODE_OF_CONDUCT.md)


Can we change the URL to point to the official repo? Please and thank you!

Cyb3rWard0g · 2021-07-03T07:40:38Z

README.md

@@ -52,6 +55,14 @@ cd ATTACK-Python-Client
 pip install .
 ```

+## Contribution
+
+* Now the Project under production, It will great if you will contribute to the project. Feel free to show your interest in to add more features and testing. Also let us know to add more in this project.


Can we change it to:

Now that the project is more stable, it would be great to get your feedback and hopefully get more contributions to the project. Let us know if you have any features in mind. We would love to collaborate to make them happen in the project.

Cyb3rWard0g · 2021-07-03T07:41:51Z

README.md

+## Contribution
+
+* Now the Project under production, It will great if you will contribute to the project. Feel free to show your interest in to add more features and testing. Also let us know to add more in this project.
+* There are some basic guidlines to contribute is first connect with to know what we are doing and expanding.


Check our basic contribution guidelines and submit an issue with your ideas.

Cyb3rWard0g · 2021-07-03T07:42:13Z

README.md

+
+* Now the Project under production, It will great if you will contribute to the project. Feel free to show your interest in to add more features and testing. Also let us know to add more in this project.
+* There are some basic guidlines to contribute is first connect with to know what we are doing and expanding.
+* Start with basic and in little bit part, One small Pr at a time.


we can remove this one

Cyb3rWard0g · 2021-07-03T07:42:52Z

README.md

+* Now the Project under production, It will great if you will contribute to the project. Feel free to show your interest in to add more features and testing. Also let us know to add more in this project.
+* There are some basic guidlines to contribute is first connect with to know what we are doing and expanding.
+* Start with basic and in little bit part, One small Pr at a time.
+* Good Title and Description about what you are adding or updating.


Be concise but clear when adding a title and description to your feature proposal.

Cyb3rWard0g · 2021-07-03T07:49:29Z

Thank you very much @thegautamkumarjaiswal and @osV22 ! I added some comments. I believe the last bullet points of the contributing section in the main read me still need the bullet points provided by @osV22 :

#26 (review)

Once again, thank you so much for taking the time to contribute to this project! 👍🏾

ghost · 2021-07-03T10:54:19Z

@Cyb3rWard0g and @osV22 Please review. I have updated.

Cyb3rWard0g · 2021-07-03T16:54:22Z

README.md

+* Check our basic contribution guidelines and submit an issue with your ideas.
+* Be concise but clear when adding a title and description to your feature proposal.
+* One pull request per issue.
+* Select one or more label when you submit an issue.


Cyb3rWard0g · 2021-07-03T16:54:49Z

README.md

+* Select one or more label when you submit an issue.
+* Make sure you are in the correct branch [Master].
+* Try to avoid sizeable changes unless warranted.
+* Be patient and polite as the project is still relatively small, which is why we would appreciate your help where possible and We will definetly reach to you, to see you awsome work.


Be patient and polite as the project is still relatively small, which is why we would appreciate your help where possible.

Cyb3rWard0g · 2021-07-03T16:58:32Z

CONTRIBUTING.md

@@ -0,0 +1,87 @@
+# Contributing Guidelines
+
+When contributing to this repository, Please first discuss the change you wish to make via issue, email, or any other method with the owners of this repository before making a change.


When contributing to this repository, please share your proposal via a GitHub issue and our discord server.

Wow! Its great if we have discord . Thanks to share I will add this.

Yes! We have a discord for the OTR community 👍🏾 feel free to join. the link is the automatic invitatio

Cyb3rWard0g · 2021-07-03T17:01:40Z

README.md

+taxii2-client >= 2.2.2
+six >= 1.15.0


taxii2-client >= 2.3.0
six >= 1.16.0

@Cyb3rWard0g anything else you would like to add and change in these files ?

I believe other than that, it looks good! Thank you again for contributing to the project :)

Cyb3rWard0g · 2021-07-03T17:18:29Z

Thank you @thegautamkumarjaiswal ! It all looks good. Merging now.

Updated README.md file

dfd2a0c

Changed some line of script and Updated more in it like Contribution Header. Defined Requirments paragraph. It will help more to engage with contributors and developers to contribute.

osV22 suggested changes Jun 12, 2021

View reviewed changes

Gautam kumar jaiswal and others added 4 commits June 12, 2021 21:40

Create CODE_OF_CONDUCT.md

ea811a3

Create CONTRIBUTING.md

31e7c01

Update CODE_OF_CONDUCT.md

8e15a11

Added the Guidelines to main the Project.

Update CONTRIBUTION.md

673ed1b

ghost changed the title ~~Updated README.md file~~ Feature Add and Update Jun 12, 2021

Cyb3rWard0g reviewed Jul 3, 2021

View reviewed changes

Gautam kumar jaiswal added 2 commits July 3, 2021 16:20

Update README.md

d01f810

Update CONTRIBUTING.md

22a5c71

Cyb3rWard0g requested changes Jul 3, 2021

View reviewed changes

Update README.md

6a0b5e6

Cyb3rWard0g approved these changes Jul 3, 2021

View reviewed changes

Cyb3rWard0g merged commit 8607746 into OTRF:master Jul 3, 2021

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Feature Add and Update #26

Feature Add and Update #26

ghost commented May 14, 2021

ghost commented Jun 11, 2021

Cyb3rWard0g commented Jun 11, 2021

ghost commented Jun 11, 2021

osV22 left a comment

ghost commented Jun 12, 2021

Cyb3rWard0g Jul 3, 2021

Cyb3rWard0g Jul 3, 2021

Cyb3rWard0g Jul 3, 2021

Cyb3rWard0g Jul 3, 2021

Cyb3rWard0g Jul 3, 2021

Cyb3rWard0g commented Jul 3, 2021

ghost commented Jul 3, 2021

Cyb3rWard0g Jul 3, 2021

Cyb3rWard0g Jul 3, 2021

Cyb3rWard0g Jul 3, 2021

ghost Jul 3, 2021

Cyb3rWard0g Jul 3, 2021

Cyb3rWard0g Jul 3, 2021

ghost Jul 3, 2021

Cyb3rWard0g Jul 3, 2021

Cyb3rWard0g commented Jul 3, 2021

		@@ -0,0 +1,87 @@
		# Contributing Guidelines

		When contributing to this repository, Please first discuss the change you wish to make via issue, email, or any other method with the owners of this repository before making a change.

Feature Add and Update #26

Feature Add and Update #26

Conversation

ghost commented May 14, 2021

ghost commented Jun 11, 2021

Cyb3rWard0g commented Jun 11, 2021

ghost commented Jun 11, 2021

osV22 left a comment

Choose a reason for hiding this comment

Contributions

ghost commented Jun 12, 2021

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Cyb3rWard0g commented Jul 3, 2021

ghost commented Jul 3, 2021

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Cyb3rWard0g commented Jul 3, 2021