Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update documentation for ind-def:textfilecontent54_object/instance for value = 0 #92

Closed
solind opened this issue Dec 13, 2019 · 1 comment
Labels
Existing Schema Update A proposal for update(s) to an existing OVAL Test/Object/State OVAL-Documentation An issue related to the documentation within an OVAL schema object. Platform Independent Issue related to the Platform Independent schema
Milestone

Comments

@solind
Copy link

solind commented Dec 13, 2019

Describe the bug
Remember OVALProject/Language#277?

Well, the schema documentation discusses positive and negative numbers in the context of the ind-def:textfilecontent54_object/instance entity -- but we don't talk about what to do if the value is set to 0.

Replication Steps (if applicable)
N/A

Expected behavior
We should probably clarify that we actually mean negative integers, and non-negative integers (instead of positive integers).

Content
I've seen CIS compliance content designed to look for instance "greater than" to 0. These can be safely changed to "greater than or equal" to 1, but that's just a work-around to avoid the ambiguity of the standard.

OVAL details (complete all those relevant)

  • Schema: ind-def/ind-sc
  • Test: textfilecontent54_test
  • Object: textfilecontent54_object
  • State: textfilecontent54_state
  • Item: textfilecontent54_item

Additional context
More of an "oh by the way" -- the schema documentation also refers to the operation enumeration value "greater than or equal" as "greater than or equals[sic]", which is incorrect. We should fix that, too.

solind pushed a commit to solind/OVAL that referenced this issue Dec 13, 2019
hanleow added a commit that referenced this issue Feb 26, 2020
@wmunyan wmunyan added Existing Schema Update A proposal for update(s) to an existing OVAL Test/Object/State Platform Independent Issue related to the Platform Independent schema labels Aug 6, 2020
@wmunyan wmunyan added this to the 5.12 milestone Aug 6, 2020
@wmunyan
Copy link
Contributor

wmunyan commented Aug 10, 2020

Closing this issue as it's already been merged into the "development" branch.

@wmunyan wmunyan closed this as completed Aug 10, 2020
@vanderpol vanderpol changed the title ind-def:textfilecontent54_object/instance documentation issue for value = 0 Update documentation for ind-def:textfilecontent54_object/instance for value = 0 Sep 30, 2024
@vanderpol vanderpol added the OVAL-Documentation An issue related to the documentation within an OVAL schema object. label Dec 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Existing Schema Update A proposal for update(s) to an existing OVAL Test/Object/State OVAL-Documentation An issue related to the documentation within an OVAL schema object. Platform Independent Issue related to the Platform Independent schema
Projects
None yet
Development

No branches or pull requests

3 participants