Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deprecated 122 oval tests with no documented usage #182

Conversation

vanderpol
Copy link
Member

This pull request is pending additional feedback from OVAL consumers. Will be decided and merged in after 11-07-2024

@vanderpol
Copy link
Member Author

vanderpol commented Nov 8, 2024

Please review the following file for cross referencing what should be deprecated: https://github.com/user-attachments/files/17378654/OVAL_Test_Usage_in_Public_and_Private_Content_Oct_2024.xlsx

Also you can search through the XSD files for "This test has been deprecated due to lack of documented usage and will be removed in version 6.0 of the language." and you should find 122 instances.

As mentioned in the last meeting on 11-7-2024, this update does not include specific schematron rules for each deprecated item, as it was beyond the scope of how much time I can spend on this effort, especially given that for OVAL 6.0, I'll be deleting all of these tests in their entirety.

@vanderpol vanderpol requested review from solind and DeafBDoor November 8, 2024 12:56
@vanderpol vanderpol self-assigned this Nov 8, 2024
@vanderpol vanderpol modified the milestone: 5.12 Nov 8, 2024
@vanderpol
Copy link
Member Author

Given our timeframe to complete both OVAL 5.12 and 6.0 by the end of the month, I'd like to merge this change into develop. If you don't have time to do a review, just let me know and I'll just proceed with my personal review.

Copy link

@solind solind left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So, this all looks okay to me after a cursory review, but honestly I don't have the energy to verify all the deprecation entries against the spreadsheet (sorry). The thing to do would be to write an XSLT (or maybe just an XPATH query) to pull out all the tests you're deprecating, and then you could compare the output to the expected results.

Didn't someone else volunteer to review this one?

@vanderpol
Copy link
Member Author

@solind no worries, and a cursory review may suffice on this as long as the files are schema valid, the deprecation stuff is literally just documentation. We'll know if I made any mistakes when I go to delete them all in OVAL 6.0. We did have another volunteer, and I added them (or hopefully I added the right person) as a reviewer.

@vanderpol vanderpol merged commit eacf9cc into develop Nov 18, 2024
@vanderpol vanderpol deleted the 154-mark-all-unused-tests-and-platforms-as-deprecated-documenting-plans-to-remove-from-specification-in-oval-60 branch December 2, 2024 14:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants