Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added several new sql dbms management systems to EntityObjectEngineType #186

Conversation

vanderpol
Copy link
Member

Added several newer SQL DBMS engines for possible future use

@vanderpol vanderpol requested a review from solind November 8, 2024 13:27
@vanderpol vanderpol self-assigned this Nov 8, 2024
@vanderpol vanderpol added this to the 5.12 milestone Nov 8, 2024
Copy link

@solind solind left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You need to make corresponding changes to the EntityItemEngineType in independent-system-characteristics-schema.xsd.

@vanderpol
Copy link
Member Author

Thanks @solind for that catch. I'm wondering if for OVAL 6.0 there's a way to prevent all of these duplicated enumerations that we tend to forget to update with time? Feels like these enumerations need to be part of a 'common' file vs duplicated in definitions and system-chars.

Update is ready for your review.

@solind
Copy link

solind commented Nov 13, 2024

I'm wondering if for OVAL 6.0 there's a way to prevent all of these duplicated enumerations that we tend to forget to update with time? Feels like these enumerations need to be part of a 'common' file vs duplicated in definitions and system-chars.

I think it should be investigated as something we could do with schema consolidation. First someone needs to research why/how it came to be the way it is now!

@vanderpol
Copy link
Member Author

@solind, I think we'd have to talk to the original guys at MITRE who developed the spec to know (maybe Jon Baker or Danny Haynes?) Either way, we are where we are... I'll ponder the level of effort to improve it for 6.0, and see if we have time.

@vanderpol vanderpol merged commit 95729c9 into develop Nov 14, 2024
@vanderpol vanderpol deleted the 185-update-entityobjectenginetype-based-on-current-sql-dbms-engines branch December 2, 2024 14:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants