Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

File Attribute Type #81

Merged
merged 1 commit into from
Mar 11, 2020
Merged

File Attribute Type #81

merged 1 commit into from
Mar 11, 2020

Conversation

wmunyan
Copy link
Contributor

@wmunyan wmunyan commented May 30, 2019

Added allowable empty string enumeration value for Entity(State|Item)FileAttributeType, per standard for other OVAL enumeration types.

Added allowable empty string enumeration value for Entity(State|Item)FileAttributeType, per standard for other OVAL enumeration types.
@wmunyan wmunyan added Existing Schema Update A proposal for update(s) to an existing OVAL Test/Object/State Microsoft Issue related to the Microsoft schema. labels May 30, 2019
@solind
Copy link

solind commented May 30, 2019

Good catch. Was there an issue associated with this?

@wmunyan
Copy link
Contributor Author

wmunyan commented May 30, 2019

@solind it was something we came across in our testing. The OVAL results added an empty element with a status of "does not exist" and it failed schema validation. Temporary workaround is to just not add the element to the file_item, since its a 0..unbounded, but wanted to keep consistency with other enums.

@isimluk
Copy link

isimluk commented Oct 24, 2019

LGTM.

@solind
Copy link

solind commented Oct 25, 2019

This is a good change because we need the state to be able to potentially accommodate a variable value. However, I don't think it's actually possible for a Windows file to have no attributes, as in that case it should have FILE_ATTRIBUTE_NORMAL, which is defined as:

"A file that does not have other attributes set. This attribute is valid only when used alone."

@solind
Copy link

solind commented Oct 29, 2019

This also needs to be closed and changed into a pull request to merge into the develop branch.

@wmunyan wmunyan changed the base branch from master to develop March 11, 2020 20:03
@hanleow hanleow merged commit bd557fe into develop Mar 11, 2020
@hanleow hanleow deleted the WIN-FILE-ATTRIBUTE branch March 11, 2020 20:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Existing Schema Update A proposal for update(s) to an existing OVAL Test/Object/State Microsoft Issue related to the Microsoft schema.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants