Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tagging issue feature #277

Closed
wants to merge 287 commits into from

Conversation

letsintegreat
Copy link
Contributor

Closes OWASP-BLT/BLT#3356

  • Start suggesting appropriate issues if the user starts typing a number just after # in the issue description
Emulator.-.BLT-Flutter.2023-04-02.01-14-11.mp4
  • Make "#{a number}" clickable while rendering an existing issue's description
Emulator.-.BLT-Flutter.2023-04-02.01-16-59.mp4

fredfalcon and others added 30 commits April 15, 2021 14:06

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
…already and - Russian Language not showing up in app closes #25
Add Divider and fields for anonymous user
Finalize Authentication with Rest APIs and enhance UI
solo-daemon and others added 24 commits March 18, 2023 11:14
Bumps [google_fonts](https://github.com/material-foundation/flutter-packages/tree/main/packages) from 3.0.1 to 4.0.3.
- [Release notes](https://github.com/material-foundation/flutter-packages/releases)
- [Commits](https://github.com/material-foundation/flutter-packages/commits/google_fonts-v4.0.3/packages)

---
updated-dependencies:
- dependency-name: google_fonts
  dependency-type: direct:production
  update-type: version-update:semver-major
...

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Bumps [intl](https://github.com/dart-lang/intl) from 0.17.0 to 0.18.0.
- [Release notes](https://github.com/dart-lang/intl/releases)
- [Changelog](https://github.com/dart-lang/intl/blob/master/CHANGELOG.md)
- [Commits](https://github.com/dart-lang/intl/commits)

---
updated-dependencies:
- dependency-name: intl
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Bumps [flutter_launcher_icons](https://github.com/fluttercommunity/flutter_launcher_icons) from 0.10.0 to 0.12.0.
- [Release notes](https://github.com/fluttercommunity/flutter_launcher_icons/releases)
- [Changelog](https://github.com/fluttercommunity/flutter_launcher_icons/blob/master/CHANGELOG.md)
- [Commits](fluttercommunity/flutter_launcher_icons@v0.10.0...v0.12.0)

---
updated-dependencies:
- dependency-name: flutter_launcher_icons
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Prevent changing state if the widget has been disposed
@justary27
Copy link
Collaborator

Why is it opening the issue in the browser?We should open the issue in the app itself.

@letsintegreat
Copy link
Contributor Author

Why is it opening the issue in the browser?We should open the issue in the app itself.

The tagged issue might not be there in the paginated response. We could request it explicitly, but then I thought once we have deep linking set up, our app will automatically catch the URL and open it in the app.

If I add the logic to request the tagged issue explicitly, it would become redundant after deep linking is set up.

@DonnieBLT
Copy link
Collaborator

@letsintegreat can you please fix the conflicts?

Copy link
Collaborator

@DonnieBLT DonnieBLT left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fix conflicts

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

add a feature to tag other issues with "#" in a new issue's description, just as we do in GitHub
8 participants