Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

2.5.4 doesn't relate to credential recovery #2394

Closed
tghosth opened this issue Nov 20, 2024 · 6 comments · Fixed by #2403
Closed

2.5.4 doesn't relate to credential recovery #2394

tghosth opened this issue Nov 20, 2024 · 6 comments · Fixed by #2403
Labels
6) PR awaiting review V2 V14 _5.0 - prep This needs to be addressed to prepare 5.0

Comments

@tghosth
Copy link
Collaborator

tghosth commented Nov 20, 2024

We have spoken about this requirement before but bottom line is that this doesn't seem to belong in "Credential Recovery"

# Description L1 L2 L3 CWE
2.5.4 [MODIFIED] Verify that default user accounts (e.g. "root", "admin", or "sa") are not present in the application or are disabled. 798

I think we have a few potential target locations:

What do people think? @elarlang

@tghosth tghosth added 4) proposal for review Issue contains clear proposal for add/change something _5.0 - prep This needs to be addressed to prepare 5.0 V2 V14 labels Nov 20, 2024
@elarlang
Copy link
Collaborator

elarlang commented Nov 20, 2024

V2 is "do authentication correctly". If default credentials are used, from V2 perspective it is handled correctly.

For me it is a V14 issue.

Not a perfect match, but V14.1 deploy is dealing with "do not put test-code", "debug modes", "demo functionality" etc to the production. But this is just the first idea, does not give "let's go for the PR" feeling.

@tghosth
Copy link
Collaborator Author

tghosth commented Nov 20, 2024

@jmanico @ryarmst @randomstuff any thoughts on this?

@jmanico
Copy link
Member

jmanico commented Nov 20, 2024

This is more user policy than general authN so I agree v14 seems better.

@randomstuff
Copy link
Contributor

I do not find it shocking to find it in V2. V14 is probably OK as well.

@ryarmst
Copy link
Collaborator

ryarmst commented Nov 21, 2024

V14 seems like a fine fit.

@tghosth
Copy link
Collaborator Author

tghosth commented Nov 22, 2024

V14.1 gives me the best vibes here, opened PR #2403

@tghosth tghosth added 6) PR awaiting review and removed 4) proposal for review Issue contains clear proposal for add/change something labels Nov 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
6) PR awaiting review V2 V14 _5.0 - prep This needs to be addressed to prepare 5.0
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants