Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Crypto appendix: allow HMAC-SHA-1 #2399

Merged
merged 2 commits into from
Nov 22, 2024
Merged

Conversation

randomstuff
Copy link
Contributor

No description provided.

@tghosth
Copy link
Collaborator

tghosth commented Nov 22, 2024

Hi @randomstuff did you discuss this with @danielcuthbert? Would want to get his sign-off before merging this.

@tghosth
Copy link
Collaborator

tghosth commented Nov 22, 2024

Is there a related open issue?

Copy link
Collaborator

@danielcuthbert danielcuthbert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm ok with this addition. Good to be specific about using SHA-1 for HMAC only and we can monitor this if anything changes

@tghosth tghosth marked this pull request as ready for review November 22, 2024 11:15
@tghosth tghosth enabled auto-merge (squash) November 22, 2024 11:15
@tghosth tghosth merged commit eea22c8 into OWASP:master Nov 22, 2024
6 checks passed
@randomstuff randomstuff deleted the crypto-hmac-sha1 branch November 24, 2024 21:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants