Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update DotNet_Security_Cheat_Sheet.md #1352

Merged
merged 4 commits into from
Mar 6, 2024
Merged

Conversation

fcerullo-cycubix
Copy link
Contributor

addition to A08 based on Microsoft documentation

Thank you for submitting a Pull Request (PR) to the Cheat Sheet Series.

🚩 If your PR is related to grammar/typo mistakes, please double-check the file for other mistakes in order to fix all the issues in the current cheat sheet.

Please make sure that for your contribution:

  • In case of a new Cheat Sheet, you have used the Cheat Sheet template.
  • All the markdown files do not raise any validation policy violation, see the policy.
  • All the markdown files follow these format rules.
  • All your assets are stored in the assets folder.
  • All the images used are in the PNG format.
  • Any references to websites have been formatted as [TEXT](URL)
  • You verified/tested the effectiveness of your contribution (e.g., the defensive code proposed is really an effective remediation? Please verify it works!).
  • The CI build of your PR pass, see the build status here.

If your PR is related to an issue, please finish your PR text with the following line:

This PR covers issue #.

Thank you again for your contribution 😃

addition to A08 based on Microsoft documentation
jmanico
jmanico previously approved these changes Mar 5, 2024
@jmanico
Copy link
Member

jmanico commented Mar 5, 2024

Nice edit thank you! I am seeing some lint errors, can you kindly fix this?

cheatsheets/DotNet_Security_Cheat_Sheet.md:799 MD032/blanks-around-lists Lists should be surrounded by blank lines [Context: "- XmlSerializer and DataContra..."]

szh
szh previously requested changes Mar 5, 2024
Copy link
Collaborator

@szh szh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Just added a missing . for .NET and a link to the MS docs

cheatsheets/DotNet_Security_Cheat_Sheet.md Outdated Show resolved Hide resolved
cheatsheets/DotNet_Security_Cheat_Sheet.md Outdated Show resolved Hide resolved
Co-authored-by: Shlomo Zalman Heigh <shlomozalmanheigh@gmail.com>
Co-authored-by: Shlomo Zalman Heigh <shlomozalmanheigh@gmail.com>
jmanico
jmanico previously approved these changes Mar 6, 2024
@jmanico jmanico dismissed szh’s stale review March 6, 2024 13:40

Accepted your commits!

@jmanico
Copy link
Member

jmanico commented Mar 6, 2024

I still see one lint error:

cheatsheets/DotNet_Security_Cheat_Sheet.md:799 MD032/blanks-around-lists Lists should be surrounded by blank lines [Context: "- XmlSerializer and DataContra..."]

@jmanico jmanico merged commit fc300fb into OWASP:master Mar 6, 2024
3 checks passed
@jmanico
Copy link
Member

jmanico commented Mar 6, 2024

Lint fixes and @szh 's commits all integrated and merged!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants