Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix some grammar mistakes in 'Denial of Service' #1424

Merged
merged 4 commits into from
Jun 5, 2024
Merged

Fix some grammar mistakes in 'Denial of Service' #1424

merged 4 commits into from
Jun 5, 2024

Conversation

devraza
Copy link
Contributor

@devraza devraza commented Jun 4, 2024

I haven't checked over the entire cheat sheet, but most of it.

@devraza devraza requested review from mackowski, jmanico and szh as code owners June 4, 2024 23:13
Copy link
Member

@jmanico jmanico left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please run these changes through grammarly or AI. statements like "any single points" are a bit jarring a just a little cleanup would help.

Copy link
Collaborator

@szh szh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jmanico
Copy link
Member

jmanico commented Jun 5, 2024

Are two reviewers enough to merge or do we need all three of us?

@szh
Copy link
Collaborator

szh commented Jun 5, 2024

@jmanico Two. The repo is intentionally configured that it only allows merging after 2 reviewers, but since you're an admin it allows you to override that. It's just best not to do that unless there's a strong reason to do so.

@szh szh merged commit 0eef57b into OWASP:master Jun 5, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants