Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated authentication.md issue #1520 #1573

Closed

Conversation

eth-developer03
Copy link
Contributor

You're A Rockstar

Thank you for submitting a Pull Request (PR) to the Cheat Sheet Series.

🚩 If your PR is related to grammar/typo mistakes, please double-check the file for other mistakes in order to fix all the issues in the current cheat sheet.

Please make sure that for your contribution:

  • In case of a new Cheat Sheet, you have used the Cheat Sheet template.
  • All the markdown files do not raise any validation policy violation, see the policy.
  • All the markdown files follow these format rules.
  • All your assets are stored in the assets folder.
  • All the images used are in the PNG format.
  • Any references to websites have been formatted as [TEXT](URL)
  • You verified/tested the effectiveness of your contribution (e.g., the defensive code proposed is really an effective remediation? Please verify it works!).
  • The CI build of your PR pass, see the build status here.

If your PR is related to an issue, please finish your PR text with the following line:

This PR fixes issue #1520.

Thank you again for your contribution 😃

Copy link
Collaborator

@mackowski mackowski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I like adding more depth to this point but I personally prefer existing wording.
I would like to change it to something like:

Ensure credential rotation when a password leak occurs, at the time of compromise identification or when authenticator technology changes. Avoid requiring periodic password changes; instead, encourage users to pick strong passwords and enable Multi-Factor Authentication (MFA). According to NIST guidelines, verifiers should not mandate arbitrary password changes (e.g., periodically).

Also "Multi-Factor Authentication (MFA)" must link to MFA cheatsheet

@szh szh linked an issue Jan 2, 2025 that may be closed by this pull request
szh
szh previously approved these changes Jan 2, 2025
Copy link
Collaborator

@szh szh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kwwall
Copy link
Collaborator

kwwall commented Jan 5, 2025

My only question is why do we have TWO PRs (this one and PR #1576) that address the same change? Let's not do that any more.

@jmanico
Copy link
Member

jmanico commented Jan 8, 2025

My only question is why do we have TWO PRs (this one and PR #1576) that address the same change? Let's not do that any more.

Dammit Kevin.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update: Authentication_Cheat_Sheet.md
6 participants