Nettacker code base major refactoring #831
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is a refactor of existing Nettacker code I've been working on recently. The (incomplete) list of changes:
- add pre-commit checks
- apply OOP approach to the application architecture
- consolidate common modules logic into a base class
- extract YAML parsing logic into a separate module
- fix some typos
- get rid of (not all) misused try/except blocks
- migrate to poetry, remove requirements.* files
- re-design configuration module
- re-design logging module
- split application logic into classes
- use `pathlib` for path related manipulations
- use context-based naming for variables, modules, directories, etc
- use module level imports (vs function level)
- use the base class for specific protocol libraries
* SSL/TLS-Modules Added the SSL/TLS modules to scan for ssl certificate vulnerabilities and to scan for old ssl/tls version or bad cipher suite. * Refactor and reformat code * Wrote new Tests Wrote tests for ssl_version_scan and ssl_certificate_scan methods and also for some utility methods. * Made the requested changes Made all the name changes for consistency. Made the requested changes to all asserts. Rewrote the is_weak_cipher method in utils. --------- Co-authored-by: Arkadii Yakovets <arkadii.yakovets@owasp.org>
|
Suppressed by #863 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist
Changes proposed in this pull request
This is a refactor of existing Nettacker code I've been working on recently.
The (incomplete) list of changes:
pathlibfor path related manipulations