Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Insecure Default - mongodb connection string #222

Merged
merged 2 commits into from
Jan 14, 2021
Merged

Insecure Default - mongodb connection string #222

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
1957f9a
Local DB only - if no DB URI present
Jan 13, 2021
96f1fac
Review suggestion/atlas or localdb only
Jan 14, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion config/env/all.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@ const port = process.env.PORT || 4000;
let db = process.env.MONGOLAB_URI || process.env.MONGODB_URI;

if (!db) {
db = process.env.NODE_ENV === 'test' ? 'mongodb://localhost:27017/nodegoat' : 'mongodb://nodegoat:owasp@nodegoat-cluster-shard-00-00.zkkl5.mongodb.net:27017,nodegoat-cluster-shard-00-01.zkkl5.mongodb.net:27017,nodegoat-cluster-shard-00-02.zkkl5.mongodb.net:27017/nodegoat?ssl=true&replicaSet=atlas-qajmlr-shard-0&authSource=admin&retryWrites=true&w=majority';
db = 'mongodb://localhost:27017/nodegoat';
}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
let db = process.env.MONGOLAB_URI || process.env.MONGODB_URI;
if (!db) {
db = process.env.NODE_ENV === 'test' ? 'mongodb://localhost:27017/nodegoat' : 'mongodb://nodegoat:owasp@nodegoat-cluster-shard-00-00.zkkl5.mongodb.net:27017,nodegoat-cluster-shard-00-01.zkkl5.mongodb.net:27017,nodegoat-cluster-shard-00-02.zkkl5.mongodb.net:27017/nodegoat?ssl=true&replicaSet=atlas-qajmlr-shard-0&authSource=admin&retryWrites=true&w=majority';
db = 'mongodb://localhost:27017/nodegoat';
}
let db = process.env.MONGODB_URI || "mongodb://localhost:27017/nodegoat";

This would revert back to how it was in c44bbd6.

MONGOLAB_URI isn't needed any more, since mLab got bought out and is moving everyone over to MongoDB Atlas. Might as well make the DB setup code match the port setup line above.


module.exports = {
Expand Down