Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add the cornucopia mobile deck. #459

Merged
merged 2 commits into from
Apr 29, 2024
Merged

Add the cornucopia mobile deck. #459

merged 2 commits into from
Apr 29, 2024

Conversation

sydseter
Copy link
Collaborator

In this pull-request:

@sydseter sydseter requested a review from rewtd April 29, 2024 12:02
github-actions bot added a commit that referenced this pull request Apr 29, 2024
github-actions bot added a commit that referenced this pull request Apr 29, 2024
github-actions bot added a commit that referenced this pull request Apr 29, 2024
github-actions bot added a commit that referenced this pull request Apr 29, 2024
github-actions bot added a commit that referenced this pull request Apr 29, 2024
github-actions bot added a commit that referenced this pull request Apr 29, 2024
github-actions bot added a commit that referenced this pull request Apr 29, 2024
github-actions bot added a commit that referenced this pull request Apr 29, 2024
github-actions bot added a commit that referenced this pull request Apr 29, 2024
github-actions bot added a commit that referenced this pull request Apr 29, 2024
github-actions bot added a commit that referenced this pull request Apr 29, 2024
github-actions bot added a commit that referenced this pull request Apr 29, 2024
github-actions bot added a commit that referenced this pull request Apr 29, 2024
github-actions bot added a commit that referenced this pull request Apr 29, 2024
github-actions bot added a commit that referenced this pull request Apr 29, 2024
github-actions bot added a commit that referenced this pull request Apr 29, 2024
github-actions bot added a commit that referenced this pull request Apr 29, 2024
github-actions bot added a commit that referenced this pull request Apr 29, 2024
github-actions bot added a commit that referenced this pull request Apr 29, 2024
github-actions bot added a commit that referenced this pull request Apr 29, 2024
github-actions bot added a commit that referenced this pull request Apr 29, 2024
github-actions bot added a commit that referenced this pull request Apr 29, 2024
github-actions bot added a commit that referenced this pull request Apr 29, 2024
github-actions bot added a commit that referenced this pull request Apr 29, 2024
github-actions bot added a commit that referenced this pull request Apr 29, 2024
github-actions bot added a commit that referenced this pull request Apr 29, 2024
github-actions bot added a commit that referenced this pull request Apr 29, 2024
github-actions bot added a commit that referenced this pull request Apr 29, 2024
github-actions bot added a commit that referenced this pull request Apr 29, 2024
github-actions bot added a commit that referenced this pull request Apr 29, 2024
github-actions bot added a commit that referenced this pull request Apr 29, 2024
Copy link
Collaborator

@rewtd rewtd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This works for now - but eventually we want to only produce "current" versions I think and probably we want to generate all cards (mobile or otherwise) at the same time.

github-actions bot added a commit that referenced this pull request Apr 29, 2024
github-actions bot added a commit that referenced this pull request Apr 29, 2024
github-actions bot added a commit that referenced this pull request Apr 29, 2024
github-actions bot added a commit that referenced this pull request Apr 29, 2024
github-actions bot added a commit that referenced this pull request Apr 29, 2024
github-actions bot added a commit that referenced this pull request Apr 29, 2024
github-actions bot added a commit that referenced this pull request Apr 29, 2024
github-actions bot added a commit that referenced this pull request Apr 29, 2024
github-actions bot added a commit that referenced this pull request Apr 29, 2024
github-actions bot added a commit that referenced this pull request Apr 29, 2024
github-actions bot added a commit that referenced this pull request Apr 29, 2024
github-actions bot added a commit that referenced this pull request Apr 29, 2024
github-actions bot added a commit that referenced this pull request Apr 29, 2024
github-actions bot added a commit that referenced this pull request Apr 29, 2024
github-actions bot added a commit that referenced this pull request Apr 29, 2024
github-actions bot added a commit that referenced this pull request Apr 29, 2024
github-actions bot added a commit that referenced this pull request Apr 29, 2024
github-actions bot added a commit that referenced this pull request Apr 29, 2024
github-actions bot added a commit that referenced this pull request Apr 29, 2024
github-actions bot added a commit that referenced this pull request Apr 29, 2024
github-actions bot added a commit that referenced this pull request Apr 29, 2024
github-actions bot added a commit that referenced this pull request Apr 29, 2024
@sydseter
Copy link
Collaborator Author

sydseter commented Apr 29, 2024

@rewtd Yes, I was thinking more that we probably need to support multiple versions for multiple editions, but implementing that now require quite a few changes. This code is still sufficient for creating multiple editions and leaflets at the same time.

@sydseter sydseter merged commit 172ad99 into master Apr 29, 2024
10 checks passed
sydseter added a commit to sydseter/cornucopia that referenced this pull request Jun 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants