Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve Encode.forHtmlAttribute docs #72

Merged
merged 4 commits into from
Jul 26, 2024

Conversation

meeque
Copy link
Contributor

@meeque meeque commented Apr 18, 2024

See issue #71.

@@ -276,6 +276,8 @@ public static void forHtmlContent(Writer out, String input)
*
* <p><b>Additional Notes</b></p>
* <ul>
* <li>When using this method, the caller must provide quotes around the attribute value.</li>
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Don't like this phrasing, but I chose it because forHtmlUnquotedAttribute() JavaDocs use similar phrasing.

@meeque
Copy link
Contributor Author

meeque commented Apr 18, 2024

Disclaimer: I've put these minor doc changes together through the Github web UI. Haven't actually generated JavaDocs from it yet.

@jeremylong jeremylong merged commit 58bd93d into OWASP:main Jul 26, 2024
@jeremylong
Copy link
Member

sorry for the delay in getting this merged.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants