Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[MSTG-CODE-3] Add iOS Debugging Symbols Inspection #1930

Merged
merged 14 commits into from
Oct 14, 2021

Conversation

su-vikas
Copy link
Collaborator

Added information on how to look for debug symbols in a compiled MachO file.

This PR closes #1868

Copy link
Collaborator

@cpholguera cpholguera left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @su-vikas thanks for another nice PR. Please take a look at the suggested changes, comments and let me know if you need any further input :)

Document/0x06i-Testing-Code-Quality-and-Build-Settings.md Outdated Show resolved Hide resolved
Document/0x06i-Testing-Code-Quality-and-Build-Settings.md Outdated Show resolved Hide resolved
Document/0x06i-Testing-Code-Quality-and-Build-Settings.md Outdated Show resolved Hide resolved
Document/0x06i-Testing-Code-Quality-and-Build-Settings.md Outdated Show resolved Hide resolved
Document/0x06i-Testing-Code-Quality-and-Build-Settings.md Outdated Show resolved Hide resolved
Document/0x06i-Testing-Code-Quality-and-Build-Settings.md Outdated Show resolved Hide resolved
Document/0x06i-Testing-Code-Quality-and-Build-Settings.md Outdated Show resolved Hide resolved
@cpholguera cpholguera changed the title Updated MSTG-CODE-3 Updated MSTG-CODE-3 - iOS Debugging Symbols Oct 14, 2021
Copy link
Collaborator

@cpholguera cpholguera left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

last set of minimal changes and we merge ;)

Copy link
Collaborator

@cpholguera cpholguera left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @su-vikas for the nice PR. Since it was open for a very long while I just applied the suggestions as per our guidelines. This way we can already close it and get you new topics to work on ;) Thanks a lot for your work and your patience!

@cpholguera cpholguera merged commit 25e816c into OWASP:master Oct 14, 2021
@su-vikas su-vikas deleted the ios_code_quality branch October 14, 2021 09:23
@cpholguera cpholguera changed the title Updated MSTG-CODE-3 - iOS Debugging Symbols [MSTG-CODE-3] Add iOS Debugging Symbols Inspection Dec 23, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

iOS Code Quality and Build Settings (MSTG-CODE-3)
2 participants