Upgrade Link Checker #1956
Merged
Upgrade Link Checker #1956
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* sh3llc0d3r.com links replaced with web archive sh3llc0d3r.com stopped resolving replaced links with web archive links. * converting http to https * stingray technologies correcting url stingray technologies url has shifted.
|
Now using |
TheDauntless
approved these changes
Oct 29, 2021
anantshri
reviewed
Oct 29, 2021
| @@ -47,5 +47,6 @@ | |||
| ], | |||
| "retryOn429": true, | |||
| "fallbackRetryDelay": "30s", | |||
| "aliveStatusCodes": [200, 403], | |||
There was a problem hiding this comment.
@cpholguera would suggest to keep it as 200 only. 403 is caused on specific links as they sit behind cloudflare or simmilar checks and they cause the test page to appear. blanket marking 403 as alive would pose different challenges for us.
anantshri
reviewed
Oct 29, 2021
| @@ -129,7 +129,7 @@ A language.lproj folder exists for each language that the application supports. | |||
|
|
|||
|  \ | |||
|
|
|||
| On a jailbroken device, you can recover the IPA for an installed iOS app using different tools that allow decrypting the main app binary and reconstruct the IPA file. Similarly, on a jailbroken device you can install the IPA file with [IPA Installer](https://github.com/autopear/ipainstaller "IPA Installer"). During mobile security assessments, developers often give you the IPA directly. They can send you the actual file or provide access to the development-specific distribution platform they use, e.g., [HockeyApp](https://hockeyapp.net/ "HockeyApp") or [TestFlight](https://developer.apple.com/testflight/ "TestFlight"). | |||
| On a jailbroken device, you can recover the IPA for an installed iOS app using different tools that allow decrypting the main app binary and reconstruct the IPA file. Similarly, on a jailbroken device you can install the IPA file with [IPA Installer](https://github.com/autopear/ipainstaller "IPA Installer"). During mobile security assessments, developers often give you the IPA directly. They can send you the actual file or provide access to the development-specific distribution platform they use, e.g. [TestFlight](https://developer.apple.com/testflight/ "TestFlight"). | |||
There was a problem hiding this comment.
@cpholguera Do we want to replace hockeyapp with appcenter https://appcenter.ms
refer: https://devblogs.microsoft.com/appcenter/hockeyapp-is-being-retired/
There was a problem hiding this comment.
That's a great idea, could you please edit the sentence again on a new PR?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Commit ID was from Apr 14, 2020. Upgraded to use v1 as indicated in the README file.
'gaurav-nelson/github-action-markdown-link-check@820c0581641b6e2fb34ae4d5f93ef4d841fb37e6' (SHA:820c0581641b6e2fb34ae4d5f93ef4d841fb37e6)