Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixing typos and more in the Android Crypto Chapter #1992

Merged
merged 5 commits into from
Jan 24, 2022

Conversation

cpholguera
Copy link
Collaborator

@cpholguera cpholguera commented Nov 30, 2021

Fixing typos, grammar, missing articles, etc.

Copy link
Collaborator

@TheDauntless TheDauntless left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A few small changes, though the 'being' thing might be a preference, as I can't find any sources that state that it is less formal.

Document/0x05e-Testing-Cryptography.md Outdated Show resolved Hide resolved
Document/0x05e-Testing-Cryptography.md Outdated Show resolved Hide resolved
Document/0x05e-Testing-Cryptography.md Outdated Show resolved Hide resolved
Document/0x05e-Testing-Cryptography.md Outdated Show resolved Hide resolved
cpholguera and others added 4 commits January 23, 2022 16:15
Co-authored-by: Jeroen Beckers <info@dauntless.be>
Co-authored-by: Jeroen Beckers <info@dauntless.be>
Co-authored-by: Jeroen Beckers <info@dauntless.be>
Co-authored-by: Jeroen Beckers <info@dauntless.be>
Copy link
Collaborator

@TheDauntless TheDauntless left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! 🐼

@cpholguera cpholguera marked this pull request as ready for review January 24, 2022 12:18
@cpholguera cpholguera merged commit 045b169 into master Jan 24, 2022
@cpholguera cpholguera deleted the fix-typos-crypto-android branch January 24, 2022 12:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants