Add Test for Implicit Intent Injection (MSTG-PLATFORM-2) #2056
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…sis in Testing for Injection Flaws (MSTG-PLATFORM-2)
…njection Flaws (MSTG-PLATFORM-2)
cpholguera
reviewed
May 7, 2022
There was a problem hiding this comment.
Just a comment for now. Sorry about the long wait @LukasMarckmiller, we are working on the MASVS refactoring for a couple of months already and that's getting all of our time. Thanks for your PR and for your patience!
| @@ -407,8 +407,151 @@ public boolean isAlphaNumeric(String s){ | |||
|
|
|||
| An alternative to validation functions is type conversion, with, for example, `Integer.parseInt` if only integers are expected. The [OWASP Input Validation Cheat Sheet](https://www.owasp.org/index.php/Input_Validation_Cheat_Sheet "OWASP Input Validation Cheat Sheet") contains more information about this topic. | |||
|
|
|||
| #### Implicit Intent Injection | |||
There was a problem hiding this comment.
Does this fix the problem? If yes, we should include this.
https://developer.android.com/about/versions/13/behavior-changes-13#intent-filters
|
unfortunately this feature does not fix the problem since the receiving app is the malicious part anyway. The core problem is not the hijacking of the intent but the improper handling of its return value. |
No problem! Im happy to contribute to the project so i can give something back to you guys! 😄 |
sushi2k
reviewed
Jan 30, 2023
sushi2k
approved these changes
Jan 30, 2023
sushi2k
approved these changes
Jan 30, 2023
TheDauntless
approved these changes
Jan 31, 2023
| @@ -407,8 +407,151 @@ public boolean isAlphaNumeric(String s){ | |||
|
|
|||
| An alternative to validation functions is type conversion, with, for example, `Integer.parseInt` if only integers are expected. The [OWASP Input Validation Cheat Sheet](https://www.owasp.org/index.php/Input_Validation_Cheat_Sheet "OWASP Input Validation Cheat Sheet") contains more information about this topic. | |||
|
|
|||
| #### Implicit Intent Injection | |||
|
|
|||
| [Implicit intents](https://developer.android.com/guide/components/intents-filters#ExampleSend "Implicit intents") are useful when the user want to use an external functionality of another app without requiring the developer to specify a particular app in the intent. For example, if the user clicks on an e-mail address within an app, an e-mail app should open and prepare a draft to the given e-mail address. However, the calling app does not want to specify a concrete e-mail app but leaves this choice to the user. | |||
There was a problem hiding this comment.
Suggested change
| [Implicit intents](https://developer.android.com/guide/components/intents-filters#ExampleSend "Implicit intents") are useful when the user want to use an external functionality of another app without requiring the developer to specify a particular app in the intent. For example, if the user clicks on an e-mail address within an app, an e-mail app should open and prepare a draft to the given e-mail address. However, the calling app does not want to specify a concrete e-mail app but leaves this choice to the user. | |
| [Implicit intents](https://developer.android.com/guide/components/intents-filters#ExampleSend "Implicit intents") are useful when the user wants to use an external functionality of another app without requiring the developer to specify a particular app in the intent. For example, if the user clicks on an e-mail address within an app, an e-mail app should open and prepare a draft to the given e-mail address. However, the calling app does not want to specify a concrete e-mail app and leaves this choice to the user. |
cpholguera
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is related to #2052 and covers the implicit intent part but the part about broadcast receiver changes in Android Oreo, mentioned in the closed issue #941 is still open.