Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add coverage for MSTG-CODE-9 on Android #2089

Merged
merged 20 commits into from
Jul 8, 2022
Merged

Add coverage for MSTG-CODE-9 on Android #2089

merged 20 commits into from
Jul 8, 2022

Conversation

cpholguera
Copy link
Collaborator

@cpholguera cpholguera commented Mar 22, 2022

The Android test "Make Sure That Free Security Features Are Activated (MSTG-CODE-9)" was wrongly covering obfuscation. Now it's corrected and covers binary anti-exploitation protections.

Overview of all changes:

Copy link
Collaborator

@TheDauntless TheDauntless left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not a real review yet, because I think the approach should maybe be a bit different. By focussing only on native files, the test would become a lot clearer.

Document/0x05i-Testing-Code-Quality-and-Build-Settings.md Outdated Show resolved Hide resolved
Document/0x05i-Testing-Code-Quality-and-Build-Settings.md Outdated Show resolved Hide resolved
Document/0x05i-Testing-Code-Quality-and-Build-Settings.md Outdated Show resolved Hide resolved
Document/0x05i-Testing-Code-Quality-and-Build-Settings.md Outdated Show resolved Hide resolved
Document/0x05i-Testing-Code-Quality-and-Build-Settings.md Outdated Show resolved Hide resolved
@cpholguera cpholguera marked this pull request as ready for review March 31, 2022 07:17
@cpholguera cpholguera changed the title Add coverage for MSTG-CODE-9 Add coverage for MSTG-CODE-9 on Android Mar 31, 2022
Copy link
Collaborator

@TheDauntless TheDauntless left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Most of them are easy fixes :)

Document/0x04c-Tampering-and-Reverse-Engineering.md Outdated Show resolved Hide resolved
Document/0x04c-Tampering-and-Reverse-Engineering.md Outdated Show resolved Hide resolved
Document/0x04c-Tampering-and-Reverse-Engineering.md Outdated Show resolved Hide resolved
Document/0x04c-Tampering-and-Reverse-Engineering.md Outdated Show resolved Hide resolved
Document/0x04c-Tampering-and-Reverse-Engineering.md Outdated Show resolved Hide resolved
Document/0x06b-Basic-Security-Testing.md Outdated Show resolved Hide resolved
Document/0x06i-Testing-Code-Quality-and-Build-Settings.md Outdated Show resolved Hide resolved
cpholguera and others added 2 commits July 8, 2022 10:22
Co-authored-by: Jeroen Beckers <info@dauntless.be>
Co-authored-by: Jeroen Beckers <info@dauntless.be>
@TheDauntless TheDauntless self-requested a review July 8, 2022 08:55
Copy link
Collaborator

@TheDauntless TheDauntless left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🥳

@cpholguera cpholguera merged commit 9ecea69 into master Jul 8, 2022
@cpholguera cpholguera deleted the code-9-android branch July 8, 2022 09:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants