-
-
Notifications
You must be signed in to change notification settings - Fork 2.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Key Management Updates for iOS and Android (by @vixentael) #2127
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Update "Protecting Keys in Memory" adding more information of keys clean up and key wrapping techniques. * Clarify IV usage, add note about popular mistake of copy-pasting example code with hardcoded IVs from OSS crypto libs. * Mention Blake3 * Add @veorq cryptocoding guidelines as reference for zeroing memory. These changes were discussed with @sushi2k and @julepka in a separate doc.
Co-authored-by: cpholguera <perezholguera@gmail.com>
Co-authored-by: Jeroen Beckers <me.githbub@dauntless.be>
Closed
6 tasks
TheDauntless
approved these changes
Jun 28, 2022
happy to see this merged! thank you @cpholguera 🤗 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is the same as
#1884
We/GitHub had some issues and we can only merge now by using this new PR (it keeps the original commits from @vixentael).
@vixentael:
I slightly refreshed crypto chapter:
These changes were discussed with @sushi2k and @julepka in a separate doc.