Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Key Management Updates for iOS and Android (by @vixentael) #2127

Merged
merged 13 commits into from
Jun 28, 2022
Merged

Conversation

cpholguera
Copy link
Collaborator

@cpholguera cpholguera commented Jun 28, 2022

This PR is the same as
#1884

We/GitHub had some issues and we can only merge now by using this new PR (it keeps the original commits from @vixentael).


@vixentael:
I slightly refreshed crypto chapter:

  • Updated "Protecting Keys in Memory" adding more information of keys clean up and key wrapping techniques.
  • Clarified IV usage, add note about popular mistake of copy-pasting example code with hardcoded IVs from OSS crypto libs.
  • Mentioned BLAKE3.
  • Added @veorq cryptocoding guidelines as reference for zeroing memory.

These changes were discussed with @sushi2k and @julepka in a separate doc.

vixentael and others added 13 commits March 26, 2021 15:07
* Update "Protecting Keys in Memory" adding more information of keys clean up and key wrapping techniques. 
* Clarify IV usage, add note about popular mistake of copy-pasting example code with hardcoded IVs from OSS crypto libs.
* Mention Blake3
* Add @veorq cryptocoding guidelines as reference for zeroing memory.

These changes were discussed with @sushi2k and @julepka in a separate doc.
Co-authored-by: cpholguera <perezholguera@gmail.com>
Co-authored-by: Jeroen Beckers <me.githbub@dauntless.be>
@vixentael
Copy link
Contributor

happy to see this merged! thank you @cpholguera 🤗

@cpholguera cpholguera changed the title Key management updates in "Testing cryptography", "Testing data storage" for iOS and Android Key management updates in "Testing cryptography", "Testing data storage" for iOS and Android (by @vixentael) Sep 5, 2022
@cpholguera cpholguera changed the title Key management updates in "Testing cryptography", "Testing data storage" for iOS and Android (by @vixentael) Key Management Updates for iOS and Android (by @vixentael) Sep 5, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants