Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MSTG-RESILIENCE-5 Update Emulation Available on iOS #2167

Merged
merged 7 commits into from
Aug 17, 2022

Conversation

t3chn0m4g3
Copy link
Collaborator

@t3chn0m4g3 t3chn0m4g3 commented Jul 22, 2022

Closes #2163

Thank you for submitting a Pull Request to the Mobile Security Testing Guide. Please make sure that:

  • Your contribution is written in the 2nd person (e.g. you)
  • Your contribution is written in an active present form for as much as possible.
  • You have made sure that the reference section is up to date (e.g. please add sources you have used, make sure that the references to MITRE/MASVS/etc. are up to date)
  • Your contribution has proper formatted markdown and/or code
  • Any references to website have been formatted as [TEXT](URL “NAME”)
  • You verified/tested the effectiveness of your contribution (e.g.: is the code really an effective remediation? Please verify it works!)

Copy link
Collaborator

@anantshri anantshri left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Besides that one spelling error. everything else seems good.

Copy link
Collaborator

@anantshri anantshri left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

Copy link
Collaborator

@cpholguera cpholguera left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is great @t3chn0m4g3! I've included some suggestions. If you agree please click on "Commit suggestion" to apply them. Thank you very much!

@cpholguera cpholguera changed the title Adjust for emulation available on iOS - This PR closes #2163 Update emulation available on iOS Aug 17, 2022
t3chn0m4g3 and others added 3 commits August 17, 2022 11:10
Perfect :) Thank you for the suggestions @cpholguera and the refinement.

Co-authored-by: Carlos Holguera <perezholguera@gmail.com>
Perfect :) Thank you for the suggestions @cpholguera and the refinement.

Co-authored-by: Carlos Holguera <perezholguera@gmail.com>
Perfect :) Thank you for the suggestions @cpholguera and the refinement.

Co-authored-by: Carlos Holguera <perezholguera@gmail.com>
@t3chn0m4g3
Copy link
Collaborator Author

Perfect :) Thank you for the suggestions @cpholguera and the refinement.

t3chn0m4g3 and others added 2 commits August 17, 2022 11:31
Co-authored-by: Carlos Holguera <perezholguera@gmail.com>
Co-authored-by: Carlos Holguera <perezholguera@gmail.com>
Copy link
Collaborator

@cpholguera cpholguera left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Now that the markdown linter is happy we can merge, thanks @t3chn0m4g3!

@t3chn0m4g3
Copy link
Collaborator Author

Awesome! Thank you for the great collaboration on this!

@cpholguera cpholguera merged commit f179bd9 into OWASP:master Aug 17, 2022
@cpholguera
Copy link
Collaborator

@t3chn0m4g3 We'll be very happy to have more contributions from you. I've added you to the OWASP MSTG project in GitHub, you should receive the invitation in a couple of seconds.

@cpholguera
Copy link
Collaborator

Are you on our Slack channel? https://github.com/OWASP/owasp-mstg#connect-with-us

If you're interested in working on another issue, please let us know by writing to the issue or via Slack and we'll assign it to you. You can also use Slack for any questions you might have. Thank you!

@t3chn0m4g3
Copy link
Collaborator Author

@cpholguera Thanks, accepted, happy to contribute.

@cpholguera cpholguera changed the title Update emulation available on iOS MSTG-RESILIENCE-5 Update Emulation Available on iOS Sep 6, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug] Landscape change, claim might not hold anymore
3 participants