Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change vertices properties from integer to number so they can be imported #1047

Merged
merged 1 commit into from
Aug 6, 2024

Conversation

mi0x
Copy link

@mi0x mi0x commented Aug 6, 2024

Summary:
This Pull Request solved the issue: closes #1046

Description for the changelog:
I have changed the type in the Schema for the vertices types to be able to accept decimals, tested it locally and it succesfully imports a model where the x or y vertices are decimals.

@jgadsden jgadsden self-requested a review August 6, 2024 13:52
@jgadsden jgadsden added bug Something isn't working blocker Functionality isn't working priority version-2.3 labels Aug 6, 2024
@jgadsden
Copy link
Collaborator

jgadsden commented Aug 6, 2024

we have a bug in the pipeline which means the docker image can not be run if required permissions are not in place
working on fixing this , but until there is a solution ignore the error in the smoke tests

@jgadsden jgadsden assigned jgadsden and unassigned jgadsden Aug 6, 2024
Copy link
Collaborator

@jgadsden jgadsden left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks for correcting this bu @mikehoogesteger and @mi0x
I will merge it in

@jgadsden jgadsden merged commit 6678aa4 into OWASP:main Aug 6, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
blocker Functionality isn't working bug Something isn't working priority version-2.3
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Exported model does not comply with the JSON scheme
2 participants