update cupcake SVGs to handle light and dark modes #940
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Specifically: 1. For cupcake alone, just add the white background-color 2. For cupcake with threat dragon text, add three rectangles: a. Firstly, a black background for the white threat dragon text b. Secondly, a white background for the black cupcake c. Thirdly, a black background, so the 'T' in threat dragon has some contrast behind it as it overlaps the second white rectangle 3. Translate the threat dragon text left a bit, so it doesn't overflow the SVG on the right side See #936
|
@jgadsden Thank you and you're welcome. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary: update cupcake SVGs to handle light and dark modes
Description for the changelog:
update cupcake SVGs to handle light and dark modes
Other info:
Specifically:
closes #936
<--
Thanks for submitting a pull request!
Please make sure you follow our code_of_conduct.md and our contributing guidelines contributing.md
-->