-
-
Notifications
You must be signed in to change notification settings - Fork 260
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: upgrade SBOM generators #964
chore: upgrade SBOM generators #964
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
good to have this @jkowalleck , and I agree the gh action being used is not the best way to create SBOMs
did you want to fix up this workflow as well? .github/workflows/push.yaml
This comment was marked as resolved.
This comment was marked as resolved.
yep. the idea was to revisit all SBOM generation workflows and upgrade then to a modern maintained system |
@jgadsden upgrade done. was unable to test successfully, since some unrelated/untouched CI jobs are skipped or dont pass. feel free to merge, or ping me in case a rebase is done and changes/updates are required. |
Signed-off-by: Jan Kowalleck <jan.kowalleck@gmail.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thanks for applying this to all the SBOM generators @jkowalleck
going ahead with the merge because the two failing tests are known issues
@jgadsden i see something is off in the SBOM process. I will drop a fix soon |
Summary:
I've seen you are shipping SBOMs with every release 👍
I've seen you are using the unmaintained github workflow
CycloneDX/gh-node-module-generatebom
to generate them.I propose to switch to the maintained
@cyclonedx/cyclonedx-npm
instead.I propose to use
@cyclonedx/webpack-plugin
for the VueJS frontendsDescription for the changelog:
chore: upgrade SBOM generators
Other info:
fixes #963