Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Aligned scope param default value with oauth spec #996

Merged
merged 1 commit into from
Jul 3, 2024

Conversation

ch-lepp
Copy link
Collaborator

@ch-lepp ch-lepp commented Jul 3, 2024

Summary:
Closes #995

Description for the changelog:
The scope params default value is separated by spaces instead of commas as defined by the oauth spec.

@jgadsden jgadsden self-requested a review July 3, 2024 15:52
@jgadsden jgadsden added bug Something isn't working multi-auth version-2.3 labels Jul 3, 2024
@jgadsden
Copy link
Collaborator

jgadsden commented Jul 3, 2024

do not worry about the failed docker build, this is due to a lack of permissions and not to the change

Copy link
Collaborator

@jgadsden jgadsden left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks for fixing this @ch-lepp , it is very good to have

@jgadsden jgadsden merged commit e567f87 into OWASP:main Jul 3, 2024
1 check passed
@ch-lepp
Copy link
Collaborator Author

ch-lepp commented Jul 3, 2024

Thx @jgadsden for reviewing and merging this PR so quickly.

Could you pls also have a look into the discussion I opened here?
I am pretty confused about the correct redirect uri...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working multi-auth version-2.3
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Malformed gitlab scope default value
2 participants