Merge pull request #101 from makerdao/CDP-415-allowances-issue

CDP-415 convert allowance and BN max uint to number before comparing
OasisDEX · Sep 5, 2019 · 4a96e67 · 4a96e67 · vercel · Sep 5, 2019
2 parents 48cc86f + fd0c22c
commit 4a96e67
Showing 1 changed file with 4 additions and 1 deletion.
diff --git a/src/reducers/multicall/accounts.js b/src/reducers/multicall/accounts.js
@@ -24,7 +24,10 @@ export function accountBalanceForToken(
             returns: [
               [
                 `accounts.${currentAddress}.allowances.${tokenSymbol}`,
-                allowance => fromWei(allowance).eq(MAX_UINT_BN)
+                // Unlimited allowance may be a tiny bit less than MAX_UINT_BN,
+                // calling .toNumber() gives us a reasonably large number to compare.
+                allowance =>
+                  fromWei(allowance).toNumber() === MAX_UINT_BN.toNumber()
               ]
             ]
           }