Refactor getStrategyConfig to handle old positions with no debt

[marcinciarka]

This pull request refactors the getStrategyConfig function to handle old positions with no debt. It includes changes to the getStrategyConfig function and the hasAssets function. Additionally, a new button has been added to the 404 page for going back (dev only).

Summary by CodeRabbit

• New Features

  • Enhanced Aave user configuration to support users with 'STETH' assets and no debts.
  • Added a button on the Not Found page for easier navigation back to the previous page during non-production modes.
  • Introduced a new translation key for the 404 error page to improve user navigation.

• Bug Fixes

  • Improved case sensitivity handling for asset names in Aave user configuration logic.

[coderabbitai]

Walkthrough

The changes in this pull request introduce enhancements to the Aave user configuration logic, including case-insensitive asset name handling and improved management of legacy positions without debts. Additionally, a new button is added to the NotFoundPage component for easier navigation during development, along with a corresponding localization entry for user interface consistency.

Changes

File	Change Summary
features/aave/helpers/getStrategyConfig.ts	Added a new case in the getStrategyConfig$ function to handle 'STETH' assets without debts.
lendingProtocols/aave-v2/pipelines/aave-user-configuration.ts	Modified asset name handling to be case-insensitive and refined logic for identifying assets without debts.
pages/not-found.tsx	Introduced a button for navigating back to the previous page when not in production mode.
public/locales/en/common.json	Added a new key "404-back": "Go back" to enhance navigation options on the 404 error page.

Sequence Diagram(s)

sequenceDiagram
    participant User
    participant NotFoundPage
    participant AppLink

    User->>NotFoundPage: Access 404 Page
    NotFoundPage->>User: Display Not Found Message
    alt Not in Production
        NotFoundPage->>AppLink: Show "Go back" Button
        User->>AppLink: Click "Go back"
        AppLink->>User: Navigate to Previous Page
    end

Loading

🐰 In the meadow, changes bloom,
A button to lift the gloom.
With assets now in line,
The code flows smooth, divine.
Hop along, let errors fade,
In this garden, progress made! 🌼

---

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share

• X
• Mastodon
• Reddit
• LinkedIn

Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>.
  • Generate unit testing code for this file.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai generate unit testing code for this file.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai generate interesting stats about this repository and render them as a table.
  • @coderabbitai show all the console.log statements in this repository.
  • @coderabbitai read src/utils.ts and generate unit testing code.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Other keywords and placeholders

• Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
• Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
• Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• Please see the configuration documentation for more information.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.

[coderabbitai]

Actionable comments posted: 0

Outside diff range and nitpick comments (1)

pages/not-found.tsx (1)

27-33: Improve button styling and accessibility.

The conditional rendering and button functionality look good! Here are a couple of suggestions to improve the code:

1. Instead of using a magic number for the top margin, consider using a value from the theme-ui spacing scale for better consistency and maintainability. For example:

-<AppLink href="/" sx={{ mt: '-20px' }}>
+<AppLink href="/" sx={{ mt: -3 }}>

2. Update the button text to be more descriptive for better accessibility. For example:

-{t('404-back')}
+{t('404-back-to-previous-page')}

And update the translation file accordingly.

Review details

Configuration used: CodeRabbit UI
Review profile: CHILL

Commits

Files that changed from the base of the PR and between 410818e and 72a74e6.

Files selected for processing (4)

• features/aave/helpers/getStrategyConfig.ts (1 hunks)
• lendingProtocols/aave-v2/pipelines/aave-user-configuration.ts (3 hunks)
• pages/not-found.tsx (1 hunks)
• public/locales/en/common.json (1 hunks)

Additional comments not posted (5)

lendingProtocols/aave-v2/pipelines/aave-user-configuration.ts (3)

12-14: LGTM!

The modification to convert all asset names in the reserveNamesDictionary to lowercase is a good change. It ensures case-insensitive lookups and prevents potential mismatches due to case sensitivity when referencing asset names.

---

69-73: LGTM!

The update to use the lowercase version of the asset name when checking if a token exists in the tokensDictionary is a good change. It ensures case-insensitive lookups and maintains consistency with the modifications made to the reserveNamesDictionary.

---

86-95: LGTM!

The refinement of the hasAssets function to include a special case for scenarios where there are no debt tokens is a good change. It introduces a more robust handling of user asset lists and ensures that the function can correctly identify asset presence even in edge cases where there is no associated debt.

The implementation using a ternary operator to conditionally check the debt tokens only if the debtToken array is not empty is clean and effective.

features/aave/helpers/getStrategyConfig.ts (1)

Line range hint 85-90: LGTM!

The new case statement correctly handles the special case for old positions with 'STETH' assets and no debt. The strategy is loaded with the appropriate parameters, and the case statement is placed in the correct order within the switch block. This change enhances the getStrategyConfig$ function to accommodate a wider range of position scenarios.

public/locales/en/common.json (1)

4-4: LGTM!

The addition of the "404-back": "Go back" key-value pair looks good. It adds a localized string for what I assume is a "Go back" button on a 404 error page, improving the user experience when encountering that error.