Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

OpenDepositBorrow AAVE V3 Strategy #414

Merged
merged 6 commits into from
Aug 10, 2023

Conversation

zerotucks
Copy link
Collaborator

@zerotucks zerotucks commented Aug 10, 2023

Ticket URL

Please provide a link to the ticket:
https://app.shortcut.com/oazo-apps/story/10883/open-deposit-borrow-strategy-v3

Description of Changes

Please list the changes introduced by this PR:

  • Refactor openDepositBorrow strategy to replicate version agnostic approach of depositBorrow strategy
  • Remove various protocol version branching approaches and rationalise to helpers in aave/common
  • Share logic used by depositBorrow and openDepositBorrow in aave/common

Note: The strategy args are not optional for borrow (still requiring args and zero amount to be passed). We can update it at later date but requires more fiddling around.

How to Test

Please provide instructions on how to test the changes in this PR:

PR Definition of Done

Please ensure the following requirements have been met before marking the PR as ready for review:

  • All checks are passing
  • PR is linked to a corresponding ticket
  • PR title is clear and concise
  • Code has been self-reviewed and any fixes or improvements noted (See Code review standards in Notion)
  • Documentation has been updated if necessary

@shortcut-integration
Copy link

This pull request has been linked to Shortcut Story #10883: Open Deposit Borrow Strategy V3.

@zerotucks zerotucks merged commit 301840e into dev Aug 10, 2023
1 check passed
@zerotucks zerotucks deleted the jamestuckett/sc-10883/open-deposit-borrow-strategy-v3 branch August 10, 2023 14:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants