Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixes for OasisPlatform #12

Merged
merged 5 commits into from
Apr 30, 2024
Merged

Fixes for OasisPlatform #12

merged 5 commits into from
Apr 30, 2024

Conversation

sambles
Copy link
Contributor

@sambles sambles commented Mar 20, 2024 •
edited
Loading

Fixes for OasisPlatform Lot3 PR

  • Fixed get_unique_filename adding extra . to file suffix
  • Fixed is_valid_url, if reference given is None then also return None
  • Fixed put('<filepath>'), storage manage was incorrectly appending the extension tar.gz to single files placed in remote storage

@sambles sambles marked this pull request as draft March 20, 2024 10:16
@sambles sambles mentioned this pull request Mar 20, 2024
Merged
@sambles sambles self-assigned this Apr 17, 2024
@sambles sambles marked this pull request as ready for review April 17, 2024 13:50
@sambles sambles merged commit b0dccf5 into develop Apr 30, 2024
6 checks passed
@sambles sambles deleted the fixes/platform-testing branch April 30, 2024 14:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@sambles sambles

Labels
None yet
Projects
Oasis Dev Team Tasks
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@sambles