Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Just a few minor tidy-ups. #16

Merged
merged 2 commits into from
Aug 26, 2019
Merged

Just a few minor tidy-ups. #16

merged 2 commits into from
Aug 26, 2019

Conversation

Spudley
Copy link
Contributor

@Spudley Spudley commented Oct 18, 2018

Hi. I was reviewing the code for this project today, and I decided to make a few tidy-ups to the code for you.

  1. I have changed the opening php tag to a full <?php rather than <? in classPhpPsdReader.php.
  2. I have fixed the Undefined index errors mentioned in issue Undefined index #15.

I am considering also adding a namespace and composer functionality, but I wanted to submit this simple set of changes first to check that you are open to pull requests.

@Oberto Oberto merged commit a0d4427 into Oberto:master Aug 26, 2019
@raicho
Copy link

raicho commented Dec 22, 2019

Nice.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants