-
Notifications
You must be signed in to change notification settings - Fork 103
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
core: update interfaces #2635
core: update interfaces #2635
Conversation
4a0f5fc
to
27cd10d
Compare
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #2635 +/- ##
==========================================
- Coverage 53.49% 53.33% -0.17%
==========================================
Files 202 202
Lines 27339 27501 +162
==========================================
+ Hits 14625 14667 +42
- Misses 10891 10986 +95
- Partials 1823 1848 +25
☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Generally LFTM, left some comments that need addressing before giving the green light.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LFTM
Update
SignedData
interface to include:Signatures() []Signature
- ReplacesSignature()
SetSignatures([]Signature) (SignedData, error)
- ReplacesSetSignature()
MessageRoots() ([][32]byte, error)
- ReplacesMessageRoot()
HashRoot() ([32]byte, error)
Also, update
Eth2SignedData
interface to include:DomainNames() []signing.DomainName
- ReplacesDomainName()
These changes to the core interfaces are done in order to prepare for the upcoming deneb ethereum upgrade.
category: feature
ticket: #2597