Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Failing test "test_randomvonmises" on master #1274

Closed
VeckoTheGecko opened this issue Jan 6, 2023 · 2 comments · Fixed by #1279
Closed

Failing test "test_randomvonmises" on master #1274

VeckoTheGecko opened this issue Jan 6, 2023 · 2 comments · Fixed by #1279

Comments

@VeckoTheGecko
Copy link
Contributor

The test_randomvonmises test is failing in the build process on master (as seen in the workflow output of #1273 ).

https://github.com/OceanParcels/parcels/blob/56e988ae0f627ec8994c656f5f4bab71154a2e47/tests/test_diffusion.py#L120-L148

@VeckoTheGecko
Copy link
Contributor Author

I think it might be to do with this line, and potentially a change in Scipy (since no change in parcels seems to have triggered the test failing).

https://github.com/OceanParcels/parcels/blob/56e988ae0f627ec8994c656f5f4bab71154a2e47/tests/test_diffusion.py#L146

@erikvansebille
Copy link
Member

Thanks for reporting this, @VeckoTheGecko! Very strange that the von mises now fails. Seems indeed to be related to the line you mention above. Where before the average of this scipy_mises list was mu (=np.pi), it is now closer to 0. I have no idea why this doesn't work on the scipy version used in the Github Actions??

I'm not in favour of simply disabling the unit test; better to check what is going on and fix it where/how we can. I'll dig a bit deeper

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants