-
Notifications
You must be signed in to change notification settings - Fork 143
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Clean up CI/CD workflows #1278
Clean up CI/CD workflows #1278
Conversation
In addition to the failing test in This can be included in the action by checking the platform, which I'm happy to implement in the coming days. |
Testing is now working on mac. Ready for feedback (sorry for the noise) Happy to wait for master to pass tests before merging this. |
Thanks @VeckoTheGecko, for this great improvement in the testing functionality! A few quick comments:
|
Not sure what happened there. Seems like they were skipped for some reason. We can check again on the next run.
Easy fix. Thanks for raising that
Actually, yes! Just went down a bit of a rabbit hole into composite actions, and updated accordingly. It should be working, let me know what you think.
All artifacts are zipped, so you can't just download plain HTML (or "open in new tab"). I know for coverage there are platforms to upload coverage reports. There could be similar platforms for testing, but I think it might not be worth it. Runs will hopefully only fail occasionally (and when they do, downloading the report isn't much overhead). Speaking of coverage, I'll implement it sometime after this PR has merged. On another note, I think the Windows builds are all failing without logs (even on PR #1273, prior to the workflow changes). Would it be worth disabling Windows builds? I'm not sure what the problem is (relevant issue) |
Also just renamed the workflow files and workflow names ot be more concise |
I've now fixed the vonmises issue in PR #1279, but don't get green ticks with Windows because of a strange error
@VeckoTheGecko, can you try to merge #1279 into this one, to see if it works then? |
@erikvansebille Just merged, hopefully those tests pass now 🤞 I'm going to dial back my activity on this PR in favour of other areas of the codebase (debugging these workflows is doing my head in). |
Looks like the tests are still failing on Windows, and I don't know if this will be a simple fix. If the macos/linux tests pass, I think we should:
|
Tests should pass now. If all is in order, feel free to squash and merge this (as most commits here are just noise). |
Co-authored-by: Vecko <36369090+VeckoTheGecko@users.noreply.github.com>
Rewrote workflows to be more concise, leveraging the setup-miniconda GitHub Action.
Changes:
setup-miniconda
test-me/*
branch namespace for future testing of CI/CD)