-
Notifications
You must be signed in to change notification settings - Fork 138
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Resolving environment file conda selector syntax #1603
Conversation
environment-name is not supported by miniconda GHA
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@erikvansebille I was taking a look at the environment.yml
file, and saw that there are doc building packages already included in there which means that docs/environment.yml
is redundant. 2f2e4f7 implements your changes from #1513 to fix this
Co-authored-by: Erik van Sebille <e.vansebille@uu.nl>
Resolved the main test failures, but still getting a failure for the following 2 tests unrelated to MPI. Any insight @erikvansebille ? Perhaps its due to the switch from mamba to conda, and we might need to compare the dependency list before and after. Logs: unit tests
integration tests
|
I did some testing, and those tests were also failing on |
This reverts commit 7d8ff50.
Max difference was 1.5258789e-05 for test_fieldset_sample* test
Doc build failure is due to the https://www.aoml.noaa.gov/phod/argo/images/argo_float_mission.jpg link not working (https://www.aoml.noaa.gov is down). It will likely come back up in a few days, so nothing of concern I think. Happy to merge pending your PR approval (and that the tolerances are ok) @erikvansebille |
Increased error in the |
@erikvansebille Would you be able to merge here? I don't think I can due to CI failure/branch protection rules, and I don't have access to the settings tab for this repo :) |
Making MPI explicitly an optional dependency that users need to install will simplify dev installation, and mean we don't have to worry about platform specific installation.
Changes:
environment.yml
)Supercedes #1471 and #1513