Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrate to new username system #66

Merged
merged 6 commits into from
Jun 9, 2023
Merged

Migrate to new username system #66

merged 6 commits into from
Jun 9, 2023

Conversation

Nuckyz
Copy link
Member

@Nuckyz Nuckyz commented May 4, 2023

No description provided.

@Nuckyz Nuckyz requested a review from DonovanDMC as a code owner May 4, 2023 18:46
@Nuckyz Nuckyz marked this pull request as draft May 4, 2023 18:47
lib/structures/User.ts Outdated Show resolved Hide resolved
Co-authored-by: Donovan Daniels <hewwo@yiff.rocks>
@DonovanDMC
Copy link
Member

We also need to figure out how we're going to deal with this (not adding webhooks to the cache)

this.author = data.author.discriminator === "0000" ? new User(data.author, client) : client.users.update(data.author);

lib/structures/User.ts Outdated Show resolved Hide resolved
@Syjalo
Copy link

Syjalo commented May 22, 2023

We also need to figure out how we're going to deal with this (not adding webhooks to the cache)

this.author = data.author.discriminator === "0000" ? new User(data.author, client) : client.users.update(data.author);

There's data.webhook_id

@DonovanDMC DonovanDMC marked this pull request as ready for review June 9, 2023 08:41
@DonovanDMC
Copy link
Member

force push to master

@DonovanDMC DonovanDMC merged commit 69ed8aa into OceanicJS:dev Jun 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants