-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Keystore field to CRD to support HTTPS #17
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jhunzik
requested review from
figliold,
dcruver,
mcalcote,
pelletier2017 and
a-asaad
June 4, 2024 23:04
a-asaad
reviewed
Jun 5, 2024
dcruver
approved these changes
Jun 5, 2024
a-asaad
reviewed
Jun 12, 2024
a-asaad
reviewed
Jun 12, 2024
a-asaad
reviewed
Jun 12, 2024
a-asaad
reviewed
Jun 12, 2024
figliold
approved these changes
Jun 12, 2024
jhunzik
changed the title
Add TLS config for server routes
Add Keystore field to CRD to support HTTPS
Jun 14, 2024
a-asaad
approved these changes
Jun 14, 2024
Hero'd on b2faec5 👍 |
mcalcote
approved these changes
Jun 14, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
About
Adds the ability to mount a keystore.jks file for setting up routes that host an HTTP server over TLS.
Hero Instructions
operator/webhook
directory:make build && minikube image load ghcr.io/octoconsulting/keip/route-webhook:0.6.0
make all
to deploy the integration route controller.kubectl apply -f https://github.com/cert-manager/cert-manager/releases/download/v1.15.0/cert-manager.yaml
k create secret generic --from-literal=password=password jks-password
kubectl apply -k operator/example
kubectl port-forward testroute-74d574bf85-tbv9m 8443:8443