-
Notifications
You must be signed in to change notification settings - Fork 281
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
any ROS2 port? #76
Comments
Hi @chopin1998, @Marwan99, |
I can try and have a go at it. I propose splitting the port into the following PRs for ease of reviewing and to allow anyone interested in helping to jump in:
@wxmerkt What do you think? Please let me know if I missed something. |
hi, i found a port here |
@Marwan99 your plan is clear and sounds good. I think it makes sense to have a maintainer for the ROS2 version - either in this repository or in a new repository in this organization. What do you think @ahornung? Thanks for the link to the port @chopin1998 - I did not look closer into it but it appears to be based on this repository. |
@iKrishneel thanks for the ping. @ahornung is the correct person to answer transferring the repo to this organisation. In either case, I believe the copyright headers and notices etc. should also be reinstated in your port |
@wxmerkt Thanks for your reply. As you suggested, I will update the headers and comments in the port. |
@iKrishneel sure, that would be good! How different is the port, would it make sense to have it within this repo as separate branch or is it too different? Ideally, you could merge it back as a pull request - or what do you think @wxmerkt ? |
@ahornung |
ROS1 is still supported until 2025 and widely used both in research and industry. Given that the code has diverged a bit, a separate repository might be the best option. Alternatively we could separate the communication and mapping parts and this would allow a single repository. @iKrishneel did you make modifications to the mapping part or mostly updated the communication parts? |
@wxmerkt I just updated the communication. |
Thanks to the work of @wep21, there is now a ROS2 port on branch |
@nuclearsandwich It appears I don't have access to the ROS2 release repository for |
@wxmerkt apologies for the delay. There was an issue with the earlier deployment of changes which has now been resolved. Please confirm access to the https://github.com/ros2-gbp/octomap_mapping-release repository and let me know if there are any other issues. Additionally, you're currently the only member of the release team. Should there be any other maintainers on it currently? |
Thank you - releases for foxy, galactic, and rolling are out now (i.e. access is working :-)). Let's add @ahornung as the creator of the library, perhaps he has additional suggestions as well. |
That change should be deployed or deploying soon. |
Fantastic, thank you! |
No description provided.
The text was updated successfully, but these errors were encountered: