-
Notifications
You must be signed in to change notification settings - Fork 11
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix double import breaking all splits #17
Conversation
Thanks for this contribution! Screen.Recording.2022-06-15.at.16.02.01.movOnly restarting the kernel of the reopened notebook and running the import brings back the javascirpt+css functionality. |
Sounds like a couple of hours wasted... |
That's strange; I just tested this on my machine and I can't reproduce the issue... |
Programs are behaving weirdly from time to time. Screen.Recording.2022-06-15.at.17.19.37.movInterestingly, the bug does only occur after I re-run the import after reopening the notebook. |
And one more important thing to note: |
Ok, I know what the issue is. I'll fix it later today. |
Could you try this again, @kolibril13? |
No idea how this slipped through the cracks... |
Really nice, now everything is working as expected. |
Feel free to merge this now. |
Looks great and does what it should do, thanks a lot for this contribution! |
Closes #14
The
injected_dependency
nodes don't get deleted properly; this has to be fixed before merging.