Fix bug where pod monitoring stops working after a while for Kubernetes agent #836
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This pull request has been linked to Shortcut Story #71688: Refactor job monitoring code to be long running. |
|
This pull request has been linked to Shortcut Story #73237: Pod monitoring seems to fail sometimes and afterwards it leaves the deployment hanging. |
scme0
approved these changes
Mar 14, 2024
| @@ -33,6 +35,21 @@ public KubernetesPodMonitor(IKubernetesPodService podService, ISystemLog log) | |||
| } | |||
|
|
|||
| async Task IKubernetesPodMonitor.StartAsync(CancellationToken cancellationToken) | |||
| { | |||
| var maxDurationSeconds = 70; | |||
There was a problem hiding this comment.
nit: should this be a const?
scme0
reviewed
Mar 14, 2024
| [TestFixture] | ||
| public class ExponentialBackoffFixture | ||
| { | ||
| readonly Foo foo = new Foo(); |
There was a problem hiding this comment.
Don't touch that, its a load bearing Foo 😛
There was a problem hiding this comment.
haha... I extracted that to a different class ...
LukeButters
approved these changes
Mar 14, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
[sc-73237]
Background
#824 starting using a Watcher to get updates for Pods. Unfortunately the Kubernetes API Server will close the connection after some time (we can't have the watch open forever).
Results
This PR adds a short timeout of 10min and reloads the status after that.
We also add a try/catch around the entire status loading so we don't silently lose track of Pod statuses.
Screenshot of Pod status loading at startup:
Status is reloaded after 10min:
How to review this PR
Quality ✔️
Pre-requisites