chore: migrate use of @testing-library/react-hooks #867
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
fionnachan
changed the title
fionnachan
changed the title
There was a problem hiding this comment.
after moving to @testing-library/react i got some type errors so had to update the packages
FYI @testing-library/react-hooks did not support react 18 and was running on react 17
| @@ -339,32 +310,31 @@ describe('useBalance', () => { | |||
| } | |||
| ]) | |||
| ) | |||
| }) | |||
There was a problem hiding this comment.
assertions shouldn't be wrapped in the same act function as it was previously
fionnachan
force-pushed
the
testing-library-react
branch
from
15763b5 to
138545f
Compare
fionnachan
force-pushed
the
testing-library-react
branch
from
138545f to
15763b5
Compare
| @@ -23,7 +23,7 @@ export function RetryableTxnsIncluder(): JSX.Element { | |||
| } = useAppState() | |||
|
|
|||
| const fetchAndUpdateDepositStatus = useCallback( | |||
| async (depositTxId, depositAssetType) => { | |||
| async (depositTxId: string, depositAssetType: AssetType | string) => { | |||
There was a problem hiding this comment.
@types/react & @types/react-dom v17 for some reason allow it to be of type any and won't throw an error but v18 will
| import { StaticJsonRpcProvider } from '@ethersproject/providers' | ||
| import { BigNumber } from 'ethers' | ||
| import { SWRConfig } from 'swr' | ||
| import { PropsWithChildren } from 'react' | ||
| import { MultiCaller } from '@arbitrum/sdk' | ||
| import { useBalance } from '../useBalance' | ||
|
|
||
| import { renderHookAsyncUseBalance } from './utils' |
There was a problem hiding this comment.
I would still keep renderHookAsyncUseBalance co-located in useBalance file.
My rationale: If there are 5 more tests like useBalance in the future.. we should have their specific renderHookAsync calls in their own files rather than bloating generic utils
Summary
it's good practice to update the library to date esp because
@testing-library/react-hooksfallbacks to react 17 instead of react 18Note:
waitForNextUpdateandwaitForValueToChangeare removed whenrenderHookwas migrated to@testing-library/reactand so there are more changes in the tests than a simple library migration / updateSteps to test
tests should work and pass as usual