Recording fixes #169
Merged
Recording fixes #169
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
3 tasks
PlasmaPower
requested changes
Oct 3, 2022
core/state/state_object.go
Outdated
| @@ -351,6 +361,13 @@ func (s *stateObject) updateTrie(db Database) Trie { | |||
| } | |||
| usedStorage = append(usedStorage, common.CopyBytes(key[:])) // Copy needed for closure | |||
| } | |||
| if len(keysToDelete) > 0 { | |||
| sort.Slice(keysToDelete, func(i, j int) bool { return keysToDelete[i].big.Cmp(keysToDelete[j].big) < 0 }) | |||
There was a problem hiding this comment.
I think we can directly compare common.Hashs as they're a [32]byte right? It's worth a try to simplify this I think.
core/state/statedb.go
Outdated
| for addr := range s.stateObjectsPending { | ||
| addressesToUpdate = append(addressesToUpdate, addressAndBig{addr, addr.Hash().Big()}) | ||
| } | ||
| sort.Slice(addressesToUpdate, func(i, j int) bool { return addressesToUpdate[i].big.Cmp(addressesToUpdate[j].big) < 0 }) |
There was a problem hiding this comment.
Same thing here, I think we can directly compare addresses
Not enough to fix recordings. Specifically, for arbone block 27,199,859
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
recording fixes.
If replay uses state.NewDeterministic, PrepareRecording can be called with validateDeleted = false. Otherwise true is required (will collect more preimages)