Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix requested block ahead of current block check #312

Merged
merged 1 commit into from
May 2, 2024

Conversation

PlasmaPower
Copy link
Collaborator

Header could be nil here, so we should check err first. Right now this results in a vague "method handler crashed" error message from the RPC if you eth_call against a header that doesn't exist, instead of the much better "header not found".

Copy link
Contributor

@magicxyyz magicxyyz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@PlasmaPower PlasmaPower merged commit 01a3566 into master May 2, 2024
3 of 4 checks passed
@PlasmaPower PlasmaPower deleted the nil-header-check branch May 2, 2024 15:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
s CLA signed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants