Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Arbitrum APIBackend's GetTransaction should return false when tx is not found #2336

Merged
merged 2 commits into from
May 23, 2024
Merged

Arbitrum APIBackend's GetTransaction should return false when tx is not found #2336

merged 2 commits into from
May 23, 2024

Conversation

ganeshvanahalli
Copy link
Contributor

No description provided.

@cla-bot cla-bot bot added the s Automatically added by the CLA bot if the creator of a PR is registered as having signed the CLA. label May 23, 2024
joshuacolvin0
joshuacolvin0 approved these changes May 23, 2024
View reviewed changes
Copy link
Member

@joshuacolvin0 joshuacolvin0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@joshuacolvin0 joshuacolvin0 mentioned this pull request May 23, 2024
Closed
@PlasmaPower PlasmaPower merged commit 620dde1 into master May 23, 2024
10 checks passed
@PlasmaPower PlasmaPower deleted the gettransaction-apibackend-bugfix branch May 23, 2024 23:50
@Tristan-Wilson Tristan-Wilson mentioned this pull request May 24, 2024
Closed
0xRektora added a commit to 0xRektora/ethers.js that referenced this pull request Jun 9, 2024
@0xRektora
hotfix: Adding 400ms delay to `getTransaction/eth_getTransactionByH…
9192cf0 
…ash` for OffchainLabs/nitro#2336
0xRektora added a commit to 0xRektora/ethers.js that referenced this pull request Jun 9, 2024
@0xRektora
hotfix: Adding 400ms delay to `getTransactionReceipt/eth_getTransac…
64af90e 
…tionByHash` for OffchainLabs/nitro#2336
0xRektora added a commit to 0xRektora/ethers.js that referenced this pull request Jun 9, 2024
@0xRektora
Revert "hotfix: Adding 400ms delay to `getTransactionReceipt/eth_ge…
85a4ffe 
…tTransactionByHash` for OffchainLabs/nitro#2336"

This reverts commit 64af90e.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@joshuacolvin0 joshuacolvin0 joshuacolvin0 approved these changes

Assignees
No one assigned
Labels
s Automatically added by the CLA bot if the creator of a PR is registered as having signed the CLA.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ganeshvanahalli @joshuacolvin0 @PlasmaPower