Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Configurable timeout for HeaderReader polling #2507

Merged
merged 2 commits into from
Jul 22, 2024

Commits on Jul 19, 2024

  1. Configurable timeout for HeaderReader polling

    Previously if the backend stopped responding the
    client.HeaderByNumber call inside the timed main loop would never
    return, meaning that if the HeaderReader was only operating in polling
    mode, calls to LastHeader would always return the last successfully
    fetched header until OldHeaderTimeout, and if that was set to a high
    duration then it would effectively always return the last successfully
    fetched header and never an error. This would lead to the chain appear
    to be stuck and not advancing to clients of HeaderReader.LastHeader.
    
    This change adds a configurable timeout on this call, defaulting to 5s.
    Other places in HeaderReader that use LastHeader use the passed-in
    context which the client can control, so no extra timeout was added for
    these.
    Tristan-Wilson committed Jul 19, 2024
    Configuration menu
    Copy the full SHA
    234278d View commit details
    Browse the repository at this point in the history

Commits on Jul 22, 2024

  1. Configuration menu
    Copy the full SHA
    9a82cae View commit details
    Browse the repository at this point in the history