Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: stop timer #2516

Merged
merged 4 commits into from
Jul 30, 2024
Merged

fix: stop timer #2516

Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
432b053
fix: stop timer
chuwt Jul 24, 2024
d527d77
Merge branch 'master' into fix-timer
PlasmaPower Jul 25, 2024
8838b9c
Merge branch 'master' into fix-timer
tsahee Jul 26, 2024
112b764
Merge branch 'master' into fix-timer
PlasmaPower Jul 30, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions wsbroadcastserver/clientconnection.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -193,6 +193,7 @@ func (cc *ClientConnection) Start(parentCtx context.Context) {
t := time.NewTimer(cc.delay)
select {
case <-ctx.Done():
t.Stop()
return
case <-t.C:
}
Expand Down Expand Up @@ -222,8 +223,10 @@ func (cc *ClientConnection) Start(parentCtx context.Context) {
timer := time.NewTimer(5 * time.Second)
select {
case <-ctx.Done():
timer.Stop()
return
case <-cc.registered:
timer.Stop()
log.Debug("ClientConnection registered with ClientManager", "client", cc.Name)
case <-timer.C:
log.Error("timed out waiting for ClientConnection to register with ClientManager", "client", cc.Name)
Expand Down
Loading