Fix DAS sync default retention period #2522
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The default retention period used when the DAS is syncing data should be the same as the default batch poster retention period, not the default maximum allowed by the DAS, since when syncing recent data, the max time bound (ahead of current time) is added to the retention period, and if it's the same as the max time allowed, this will be in the future.
cla-bot
bot
added
the
s
amsanghi
approved these changes
Jul 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The default retention period used when the DAS is syncing data should be the same as the default batch poster retention period, not the default maximum allowed by the DAS, since when syncing recent data, the max time bound (ahead of current time) is added to the retention period, and if it's the same as the max time allowed, this will be in the future.